Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10256 )
Change subject: PREVIEW - IMPALA-6957: calc thread resource requirement in planner ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/10256/4/testdata/workloads/functional-planner/queries/PlannerTest/spillable-buffer-sizing.test File testdata/workloads/functional-planner/queries/PlannerTest/spillable-buffer-sizing.test: http://gerrit.cloudera.org:8080/#/c/10256/4/testdata/workloads/functional-planner/queries/PlannerTest/spillable-buffer-sizing.test@10 PS4, Line 10: threads maybe at this level (and below) it should be thread-reservation, just like for memory? Since this isn't necessarily the number of threads we'll use, but the number we'll additionally require (i.e. reserve). -- To view, visit http://gerrit.cloudera.org:8080/10256 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I982837ef883457fa4d2adc3bdbdc727353469140 Gerrit-Change-Number: 10256 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 07 May 2018 21:36:37 +0000 Gerrit-HasComments: Yes
