Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10256 )
Change subject: PREVIEW - IMPALA-6957: calc thread resource requirement in planner ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/10256/4/testdata/workloads/functional-planner/queries/PlannerTest/spillable-buffer-sizing.test File testdata/workloads/functional-planner/queries/PlannerTest/spillable-buffer-sizing.test: http://gerrit.cloudera.org:8080/#/c/10256/4/testdata/workloads/functional-planner/queries/PlannerTest/spillable-buffer-sizing.test@10 PS4, Line 10: threads > +1, this also works in sync with how "Threads" are mentioned at Line 6 with Done http://gerrit.cloudera.org:8080/#/c/10256/4/testdata/workloads/functional-planner/queries/PlannerTest/spillable-buffer-sizing.test@64 PS4, Line 64: instances > not your change, but it would great if we can either call this "total-insta I'm open to the idea but maybe we should decouple it from this change? The other common point of confusion with this number is that it's the estimated number of instances only - the actual number is determined during scheduling. Maybe it should be total-instances-estimate or similar -- To view, visit http://gerrit.cloudera.org:8080/10256 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I982837ef883457fa4d2adc3bdbdc727353469140 Gerrit-Change-Number: 10256 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 08 May 2018 17:14:36 +0000 Gerrit-HasComments: Yes
