Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21340 )

Change subject: IMPALA-13024: Ignore slots if using default pool and empty group
......................................................................


Patch Set 6: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/21340/6/tests/custom_cluster/test_executor_groups.py
File tests/custom_cluster/test_executor_groups.py:

http://gerrit.cloudera.org:8080/#/c/21340/6/tests/custom_cluster/test_executor_groups.py@409
PS6, Line 409: TRIVIAL_SCAN_QUERY
nit: the "TRIVIAL_SCAN" looks ambiguous to me - IMO it would be clearer to use 
SINGLE_NODE_SCAN_QUERY?



--
To view, visit http://gerrit.cloudera.org:8080/21340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b08dea7ba0c78ac6b98c7a0b148df8fb036c4d0
Gerrit-Change-Number: 21340
Gerrit-PatchSet: 6
Gerrit-Owner: Riza Suminto <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Wed, 24 Apr 2024 12:32:16 +0000
Gerrit-HasComments: Yes

Reply via email to