Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21340 )
Change subject: IMPALA-13024: Ignore slots if using default pool and empty group ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/21340/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21340/7//COMMIT_MSG@13 PS7, Line 13: only)"). This patch adds check to recognize coordinator-only query in > nits: Done http://gerrit.cloudera.org:8080/#/c/21340/7/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/21340/7/be/src/scheduling/admission-controller.cc@998 PS7, Line 998: // Can't admit if: : // (a) There are already queued requests (and this is not admitting from the queue). : // (b) The resource pool is already at the maximum number of requests. : // (c) One of the executors or coordinator in 'schedule' is already at its maximum : // admission slots (when not using the default executor group). : // (d) There are not enough memory resources available for the query. > The comment could probably also be updated: Done -- To view, visit http://gerrit.cloudera.org:8080/21340 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0b08dea7ba0c78ac6b98c7a0b148df8fb036c4d0 Gerrit-Change-Number: 21340 Gerrit-PatchSet: 8 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 26 Apr 2024 16:04:13 +0000 Gerrit-HasComments: Yes
