Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21345 )
Change subject: IMPALA-12997: Use graceful shutdown for query log tests ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/21345/1/tests/custom_cluster/test_query_log.py File tests/custom_cluster/test_query_log.py: http://gerrit.cloudera.org:8080/#/c/21345/1/tests/custom_cluster/test_query_log.py@720 PS1, Line 720: client2 = self.create_client_for_nth_impalad(1, vector.get_value('protocol')) > impalad_graceful_shutdown stays False for this test. That does seem like it could be an issue. I'll look into ensuring it also shuts down gracefully, just can't use impalad_graceful_shutdown as is. -- To view, visit http://gerrit.cloudera.org:8080/21345 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia123c53a952a77ff4a9c02736b5717ccaa3566dc Gerrit-Change-Number: 21345 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 24 Apr 2024 20:56:33 +0000 Gerrit-HasComments: Yes
