Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21345 )
Change subject: IMPALA-12997: Use graceful shutdown for query log tests ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/21345/3/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/21345/3/tests/common/custom_cluster_test_suite.py@223 PS3, Line 223: allow_stopped=True > What if we keep allow_stopped=False by default, but override teardown_metho We haven't previously checked. Without graceful shutdown, impalad is only stopped when restarting with start_impala_cluster, which doesn't care if any are there. However I think I agree it would be useful to catch, so I'll look into improving it. -- To view, visit http://gerrit.cloudera.org:8080/21345 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia123c53a952a77ff4a9c02736b5717ccaa3566dc Gerrit-Change-Number: 21345 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 24 Apr 2024 23:14:26 +0000 Gerrit-HasComments: Yes
