Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21131 )
Change subject: IMPALA-11499: Refactor UrlEncode function to handle special characters ...................................................................... Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/21131/9//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21131/9//COMMIT_MSG@18 PS9, Line 18: '\xFF', which is an invalid UTF-8 byte is replaced with '\x7F', I don't see '\x7F' in the final code, did you change the approach and not update the commit? Daniel's comment suggested we should include it. http://gerrit.cloudera.org:8080/#/c/21131/6/be/src/util/coding-util.cc File be/src/util/coding-util.cc: http://gerrit.cloudera.org:8080/#/c/21131/6/be/src/util/coding-util.cc@69 PS6, Line 69: if (in.empty()) { > Could use a range-based for-loop: for (char ch : in) {...}. Not without an adapter. string_view(in, in_len) would work. -- To view, visit http://gerrit.cloudera.org:8080/21131 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88c4aba5d811dfcec809583d0c16fcbc0ca730fb Gerrit-Change-Number: 21131 Gerrit-PatchSet: 9 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Fri, 26 Apr 2024 21:10:42 +0000 Gerrit-HasComments: Yes
