[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/21131 )
Change subject: IMPALA-11499: Refactor UrlEncode function to handle special characters ...................................................................... Patch Set 10: (2 comments) > Patch Set 10: > > Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10587/ > DRY_RUN=true http://gerrit.cloudera.org:8080/#/c/21131/9//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21131/9//COMMIT_MSG@18 PS9, Line 18: '\xFF', which is an invalid UTF-8 byte is replaced with '\x7F', > I don't see '\x7F' in the final code, did you change the approach and not u Done http://gerrit.cloudera.org:8080/#/c/21131/6/be/src/util/coding-util.cc File be/src/util/coding-util.cc: http://gerrit.cloudera.org:8080/#/c/21131/6/be/src/util/coding-util.cc@69 PS6, Line 69: *out = ""; > Not without an adapter. string_view(in, in_len) would work. Done -- To view, visit http://gerrit.cloudera.org:8080/21131 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88c4aba5d811dfcec809583d0c16fcbc0ca730fb Gerrit-Change-Number: 21131 Gerrit-PatchSet: 10 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Sat, 27 Apr 2024 04:37:38 +0000 Gerrit-HasComments: Yes
