Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21343 )
Change subject: IMPALA-13020: Use 64-bit integer for Thrift max message size on C++ ...................................................................... Patch Set 2: (2 comments) Updated Thrift change: https://github.com/joemcdonnell/thrift/commit/7eaca019499ec8d9e1e739170197c33b1d6eb8e7 http://gerrit.cloudera.org:8080/#/c/21343/2/source/thrift/thrift-0.16.0-patches/0007-IMPALA-13020-Use-64-bit-integer-for-max-message-size.patch File source/thrift/thrift-0.16.0-patches/0007-IMPALA-13020-Use-64-bit-integer-for-max-message-size.patch: http://gerrit.cloudera.org:8080/#/c/21343/2/source/thrift/thrift-0.16.0-patches/0007-IMPALA-13020-Use-64-bit-integer-for-max-message-size.patch@35 PS2, Line 35: int maxFrameSize > Do we need to change this as well? This is only used by the TFramedTransport, which we don't use. Also, TFramedTransport has always had a limit on frame size, even in older Thrift versions like 0.11, and they just centralized it in TConfiguration. http://gerrit.cloudera.org:8080/#/c/21343/2/source/thrift/thrift-0.16.0-patches/0007-IMPALA-13020-Use-64-bit-integer-for-max-message-size.patch@79 PS2, Line 79: resetConsumedMessageSize > Do we need to change the parameter type of this too? Good catch, yes, we need this to use int64_t. Fixed. -- To view, visit http://gerrit.cloudera.org:8080/21343 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I94fdd7b07fcc8dca0639839b40a9eff815090835 Gerrit-Change-Number: 21343 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Sat, 27 Apr 2024 01:20:18 +0000 Gerrit-HasComments: Yes
