Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21343 )
Change subject: IMPALA-13020: Use 64-bit integer for Thrift max message size on C++ ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/21343/3/source/thrift/thrift-0.16.0-patches/0007-IMPALA-13020-Use-64-bit-integer-for-max-message-size.patch File source/thrift/thrift-0.16.0-patches/0007-IMPALA-13020-Use-64-bit-integer-for-max-message-size.patch: http://gerrit.cloudera.org:8080/#/c/21343/3/source/thrift/thrift-0.16.0-patches/0007-IMPALA-13020-Use-64-bit-integer-for-max-message-size.patch@24 PS3, Line 24: > Are these trailing spaces normal in patch files? The patch uses the first character for the +/- and indents everything by one space (including empty lines), so this trailing space looks normal for those lines. Separately, the Thrift codebase also has some trailing spaces on the lines I changed and the surrounding context. -- To view, visit http://gerrit.cloudera.org:8080/21343 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I94fdd7b07fcc8dca0639839b40a9eff815090835 Gerrit-Change-Number: 21343 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 30 Apr 2024 16:44:17 +0000 Gerrit-HasComments: Yes
