Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21376 )
Change subject: IMPALA-13047: Support restarting/killing specified impalads in start-impala-cluster.py ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/21376/1/bin/start-impala-cluster.py File bin/start-impala-cluster.py: http://gerrit.cloudera.org:8080/#/c/21376/1/bin/start-impala-cluster.py@95 PS1, Line 95: Start Nit: Starts. http://gerrit.cloudera.org:8080/#/c/21376/1/bin/start-impala-cluster.py@275 PS1, Line 275: kill_processes([t for t in find_user_processes(binary_names)], force) Could use "list(find_user_processes(binary_names))" instead of list comprehension. http://gerrit.cloudera.org:8080/#/c/21376/1/bin/start-impala-cluster.py@833 PS1, Line 833: node_ids[i] Optional: could extract into a variable, also used on L840. http://gerrit.cloudera.org:8080/#/c/21376/1/bin/start-impala-cluster.py@1118 PS1, Line 1118: assert existing_cluster_size == expected_cluster_size,\ If we kill some impalads, doesn't that change the cluster size? If I try to kill impalad1 first, then impalad2, this assertion is triggered. $ bin/start-impala-cluster.py $ bin/start-impala-cluster.py --kill --impalad_ids 1 13:13:50 MainThread: Found 3 impalad/1 statestored/1 catalogd process(es) 13:13:50 MainThread: Killed impalad (pid 369056) $ bin/start-impala-cluster.py --kill --impalad_ids 2 13:13:53 MainThread: Found 2 impalad/1 statestored/1 catalogd process(es) Traceback (most recent call last): File "bin/start-impala-cluster.py", line 1119, in <module> "Commands on specified impalads shouldn't change the cluster size" AssertionError: Commands on specified impalads shouldn't change the cluster size -- To view, visit http://gerrit.cloudera.org:8080/21376 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id4a863853341959eb6870b662d82188e7d570971 Gerrit-Change-Number: 21376 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 30 Apr 2024 11:16:29 +0000 Gerrit-HasComments: Yes
