Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21371 )
Change subject: IMPALA-13044: Upgrade bouncycastle to 1.78 ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/21371/3/fe/pom.xml File fe/pom.xml: http://gerrit.cloudera.org:8080/#/c/21371/3/fe/pom.xml@603 PS3, Line 603: <groupId>org.bouncycastle</groupId> Keycloak used a similar approach in https://github.com/keycloak/keycloak/pull/21543. I think this is probably ok if it passes tests. We seem to have some test coverage in test_saml2_sso.py. However I think we need an entry for this in "enforce-banned-dependencies". When I look at mvn -f fe dependency:tree -Dscope=compile it looks ok. Test dependencies look like they might still pull in some other versions though. -- To view, visit http://gerrit.cloudera.org:8080/21371 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8372916ab79b863e7a07d22e8333abd54492fa29 Gerrit-Change-Number: 21371 Gerrit-PatchSet: 3 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Tue, 30 Apr 2024 20:44:02 +0000 Gerrit-HasComments: Yes
