Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21371 )
Change subject: IMPALA-13044: Upgrade bouncycastle to 1.78 ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/21371/4/fe/pom.xml File fe/pom.xml: http://gerrit.cloudera.org:8080/#/c/21371/4/fe/pom.xml@893 PS4, Line 893: <exclude>org.bouncycastle:bcprov-jdk15on:*:compile</exclude> : <exclude>org.bouncycastle:bcprov-jdk15on:*:runtime</exclude> : <exclude>org.bouncycastle:bcpkix-jdk15on:*:compile</exclude> : <exclude>org.bouncycastle:bcpkix-jdk15on:*:runtime</exclude> I would ban/exclude for all scopes. The test scope is where we actually refer to org.bouncycastle in our code, and some of our dependencies bring in random versions of org.bouncycastle at the test scope. I would also ban the "jdk15to18" type of jar as well. Getting to a single version everywhere makes it easier to think about. -- To view, visit http://gerrit.cloudera.org:8080/21371 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8372916ab79b863e7a07d22e8333abd54492fa29 Gerrit-Change-Number: 21371 Gerrit-PatchSet: 4 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Thu, 02 May 2024 16:48:26 +0000 Gerrit-HasComments: Yes
