Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10327 )
Change subject: IMPALA-6907: Close stale connections to removed cluster members ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/10327/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10327/3//COMMIT_MSG@25 PS3, Line 25: Can you also add a comment stating the changes to impala_cluster.py? http://gerrit.cloudera.org:8080/#/c/10327/3/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/10327/3/be/src/service/impala-server.cc@1541 PS3, Line 1541: exec_env_->impalad_client_cache()->CloseConnections(entry->second.address); nit: Add comment about closing connections. http://gerrit.cloudera.org:8080/#/c/10327/3/tests/custom_cluster/test_restart_services.py File tests/custom_cluster/test_restart_services.py: http://gerrit.cloudera.org:8080/#/c/10327/3/tests/custom_cluster/test_restart_services.py@57 PS3, Line 57: def test_restart_impala(self): There's no part in this test that's actually validating that the connections are getting flushed, right? Are we saying that if the query after an impalad restart succeeds, then that means the connections got flushed? http://gerrit.cloudera.org:8080/#/c/10327/3/tests/custom_cluster/test_restart_services.py@72 PS3, Line 72: # Sleep for a bit for the statestore change in membership to propagate nit: Could you add the lower bound time it would take the statestore to propagate the change in membership, in the comment? -- To view, visit http://gerrit.cloudera.org:8080/10327 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41b7297cf665bf291b09b23524d19b1d10ab281d Gerrit-Change-Number: 10327 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Comment-Date: Tue, 08 May 2018 17:11:51 +0000 Gerrit-HasComments: Yes
