Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10327 )
Change subject: IMPALA-6907: Close stale connections to removed cluster members ...................................................................... Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/10327/3/tests/custom_cluster/test_restart_services.py File tests/custom_cluster/test_restart_services.py: http://gerrit.cloudera.org:8080/#/c/10327/3/tests/custom_cluster/test_restart_services.py@57 PS3, Line 57: def test_restart_impala(self): > Yes, the way the client cache code is structured makes it hard to discern w We technically could introduce a test only function that checks the number of stale connections in the cache, and have a way to call that from here, but I think that's not necessary, and it's going to probably introduce a lot more complexity. So, I think this is fine for now. -- To view, visit http://gerrit.cloudera.org:8080/10327 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41b7297cf665bf291b09b23524d19b1d10ab281d Gerrit-Change-Number: 10327 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Comment-Date: Wed, 09 May 2018 18:00:13 +0000 Gerrit-HasComments: Yes
