Noemi Pap-Takacs has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21388 )

Change subject: IMPALA-12867: Filter files to OPTIMIZE based on file size (WIP)
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/21388/1/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java
File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java:

http://gerrit.cloudera.org:8080/#/c/21388/1/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@183
PS1, Line 183:       dataFilesWithoutDeletes_ =
> line too long (96 > 90)
Done


http://gerrit.cloudera.org:8080/#/c/21388/1/fe/src/test/java/org/apache/impala/util/IcebergFileFilterTest.java
File fe/src/test/java/org/apache/impala/util/IcebergFileFilterTest.java:

http://gerrit.cloudera.org:8080/#/c/21388/1/fe/src/test/java/org/apache/impala/util/IcebergFileFilterTest.java@123
PS1, Line 123:     // Add data files with deletes to check if they are 
considered in the 1 file per
> line too long (100 > 90)
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/21388
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfbb589513aacdb68a86c1aec4a0d39b12091820
Gerrit-Change-Number: 21388
Gerrit-PatchSet: 2
Gerrit-Owner: Noemi Pap-Takacs <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Mon, 06 May 2024 14:18:37 +0000
Gerrit-HasComments: Yes

Reply via email to