Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21388 )
Change subject: IMPALA-12867: Filter files to OPTIMIZE based on file size (WIP) ...................................................................... Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/21388/6/fe/src/main/java/org/apache/impala/util/IcebergOptimizeFileFilter.java File fe/src/main/java/org/apache/impala/util/IcebergOptimizeFileFilter.java: http://gerrit.cloudera.org:8080/#/c/21388/6/fe/src/main/java/org/apache/impala/util/IcebergOptimizeFileFilter.java@45 PS6, Line 45: public FileFilteringResult(TIcebergOptimizationMode mode, List<DataFile> selectedFiles) { line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/21388/6/fe/src/main/java/org/apache/impala/util/IcebergOptimizeFileFilter.java@129 PS6, Line 129: TIcebergOptimizationMode mode = calculateOptimizationMode(args.filesToFilter_, selectedFiles); line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/21388/6/fe/src/test/java/org/apache/impala/util/IcebergFileFilterTest.java File fe/src/test/java/org/apache/impala/util/IcebergFileFilterTest.java: http://gerrit.cloudera.org:8080/#/c/21388/6/fe/src/test/java/org/apache/impala/util/IcebergFileFilterTest.java@69 PS6, Line 69: TIcebergOptimizationMode expectedMode, int expectedSize, Set<String> expectedPaths) { line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/21388/6/tests/query_test/test_iceberg.py File tests/query_test/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/21388/6/tests/query_test/test_iceberg.py@1735 PS6, Line 1735: # flake8: E265 block comment should start with '# ' http://gerrit.cloudera.org:8080/#/c/21388/6/tests/query_test/test_iceberg.py@1825 PS6, Line 1825: # flake8: E265 block comment should start with '# ' -- To view, visit http://gerrit.cloudera.org:8080/21388 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icfbb589513aacdb68a86c1aec4a0d39b12091820 Gerrit-Change-Number: 21388 Gerrit-PatchSet: 6 Gerrit-Owner: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 09 Jul 2024 15:33:59 +0000 Gerrit-HasComments: Yes
