[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/21131 )
Change subject: IMPALA-11499: Refactor UrlEncode function to handle special characters ...................................................................... Patch Set 21: (11 comments) > Uploaded patch set 21. http://gerrit.cloudera.org:8080/#/c/21131/19/be/src/util/coding-util-test.cc File be/src/util/coding-util-test.cc: http://gerrit.cloudera.org:8080/#/c/21131/19/be/src/util/coding-util-test.cc@97 PS19, Line 97: "\x11\x12\x13\x14\x15\x16\x17\x18\x19\x1A\x1B\x1C\x1D\x1E\x1F\x7F\"#%'" > Why is the single quote escaped? Done http://gerrit.cloudera.org:8080/#/c/21131/20/be/src/util/coding-util-test.cc File be/src/util/coding-util-test.cc: http://gerrit.cloudera.org:8080/#/c/21131/20/be/src/util/coding-util-test.cc@98 PS20, Line 98: "*/:=?\\{[]^"; > Please add '^' Done http://gerrit.cloudera.org:8080/#/c/21131/20/be/src/util/coding-util-test.cc@104 PS20, Line 104: } > nit: remove blank line Done http://gerrit.cloudera.org:8080/#/c/21131/20/tests/query_test/test_insert.py File tests/query_test/test_insert.py: http://gerrit.cloudera.org:8080/#/c/21131/20/tests/query_test/test_insert.py@297 PS20, Line 297: def test_escaped_partition_values(self, unique_database): > nit: move this inside the method, i.e. Done http://gerrit.cloudera.org:8080/#/c/21131/20/tests/query_test/test_insert.py@299 PS20, Line 299: > nit: use 2 spaces indention Done http://gerrit.cloudera.org:8080/#/c/21131/20/tests/query_test/test_insert.py@300 PS20, Line 300: > wrap this to be Done http://gerrit.cloudera.org:8080/#/c/21131/20/tests/query_test/test_insert.py@301 PS20, Line 301: ) > flake8: E501 line too long (104 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/21131/20/tests/query_test/test_insert.py@302 PS20, Line 302: > Single quote is missing here. The two single quotes in the middle doesn't r Done http://gerrit.cloudera.org:8080/#/c/21131/20/tests/query_test/test_insert.py@303 PS20, Line 303: > wrap this to be Done http://gerrit.cloudera.org:8080/#/c/21131/20/tests/query_test/test_insert.py@305 PS20, Line 305: special_characters = "SpecialCharacters\x01\x02\x03\x04\x05\x06\x07\b\t\n\v\f\r" \ > This just verifies the partition value. We still need to verify the partiti Done http://gerrit.cloudera.org:8080/#/c/21131/20/tests/query_test/test_insert.py@306 PS20, Line 306: "\x0E\x0F\x10\x11\x12\x13\x14\x15\x16\x17\x18\x19\x1A\x1B" \ > Can you add a comment about why splitting this out was necessary? "\\\\" is used to represent a backslash as it gets escaped again during parsing of the insert statement. It is no more needed as we introduce a part_value variable to store the correct string. -- To view, visit http://gerrit.cloudera.org:8080/21131 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88c4aba5d811dfcec809583d0c16fcbc0ca730fb Gerrit-Change-Number: 21131 Gerrit-PatchSet: 21 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Tue, 07 May 2024 04:38:56 +0000 Gerrit-HasComments: Yes
