[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/21131 )
Change subject: IMPALA-11499: Refactor UrlEncode function to handle special characters ...................................................................... Patch Set 21: (5 comments) > Patch Set 21: > > (11 comments) > > > Uploaded patch set 21. http://gerrit.cloudera.org:8080/#/c/21131/20/be/src/util/coding-util-test.cc File be/src/util/coding-util-test.cc: http://gerrit.cloudera.org:8080/#/c/21131/20/be/src/util/coding-util-test.cc@96 PS20, Line 96: string test = "SpecialCharacters\x01\x02\x03\x04\x05\x06\x07\b\t\n\v\f\r\x0E\x0F\x10" > line too long (91 > 90) Done http://gerrit.cloudera.org:8080/#/c/21131/21/tests/query_test/test_insert.py File tests/query_test/test_insert.py: http://gerrit.cloudera.org:8080/#/c/21131/21/tests/query_test/test_insert.py@301 PS21, Line 301: ) > flake8: E501 line too long (91 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/21131/21/tests/query_test/test_insert.py@310 PS21, Line 310: \ > flake8: W605 invalid escape sequence '\{' Done http://gerrit.cloudera.org:8080/#/c/21131/21/tests/query_test/test_insert.py@311 PS21, Line 311: \ > flake8: E501 line too long (91 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/21131/21/tests/query_test/test_insert.py@320 PS21, Line 320: e > flake8: E501 line too long (94 > 90 characters) Done -- To view, visit http://gerrit.cloudera.org:8080/21131 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88c4aba5d811dfcec809583d0c16fcbc0ca730fb Gerrit-Change-Number: 21131 Gerrit-PatchSet: 21 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Tue, 07 May 2024 04:39:54 +0000 Gerrit-HasComments: Yes
