Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10349
Change subject: IMPALA-6995: avoid DCHECK in TimestampParse::Parse() ...................................................................... IMPALA-6995: avoid DCHECK in TimestampParse::Parse() The bug was that the string's length is checked before trimming leading and trailing spaces instead of afterwards. The bug has been present for a long time but couldn't hit a DCHECK until recently. Testing: Added some backend tests that reproduce the crash. Change-Id: I02a18ffd8893fe74f5830144300f745ce31477b1 --- M be/src/exprs/expr-test.cc M be/src/runtime/timestamp-parse-util.cc 2 files changed, 14 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/49/10349/1 -- To view, visit http://gerrit.cloudera.org:8080/10349 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I02a18ffd8893fe74f5830144300f745ce31477b1 Gerrit-Change-Number: 10349 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <[email protected]>
