Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10349 )
Change subject: IMPALA-6995: avoid DCHECK in TimestampParse::Parse() ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10349/1/be/src/runtime/timestamp-parse-util.cc File be/src/runtime/timestamp-parse-util.cc: http://gerrit.cloudera.org:8080/#/c/10349/1/be/src/runtime/timestamp-parse-util.cc@399 PS1, Line 399: *d = boost::gregorian::date(); : *t = boost::posix_time::time_duration(boost::posix_time::not_a_date_time); > From a code refactoring perspective, I would suggest you make a new static Created a helper function. I actually ended up refactoring the handling of lengths in this function too in order to better distinguish the different length values. -- To view, visit http://gerrit.cloudera.org:8080/10349 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I02a18ffd8893fe74f5830144300f745ce31477b1 Gerrit-Change-Number: 10349 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Kim Jin Chul <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 09 May 2018 20:54:22 +0000 Gerrit-HasComments: Yes
