Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21437 )
Change subject: IMPALA-12277: Fix NullPointerException for partitioned inserts when EP is turned off ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/21437/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21437/1//COMMIT_MSG@11 PS1, Line 11: NullPointerException What is the source of NPE? Where does it hit / manifest problem? http://gerrit.cloudera.org:8080/#/c/21437/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/21437/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1748 PS1, Line 1748: not active Do you mean "not active or not healthy." ? // possible status of event processor public enum EventProcessorStatus { PAUSED, // event processor is paused because catalog is being reset concurrently ACTIVE, // event processor is scheduled at a given frequency ERROR, // event processor is in error state and event processing has stopped NEEDS_INVALIDATE, // event processor could not resolve certain events and needs a // manual invalidate command to reset the state (See AlterEvent for a example) STOPPED, // event processor is shutdown. No events will be processed DISABLED // event processor is not configured to run } http://gerrit.cloudera.org:8080/#/c/21437/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1751 PS1, Line 1751: (HdfsTable) tbl).load(reuseMetadata, msClient.getHiveClient(), msTbl, This line remains unchanged for a long time since Fri Dec 18 14:31:24 (IMPALA-1480: Slow DDL statements with large number of partitions), presumably even before Impala have HMS Event Processor. What is recently change that makes this cause a problem? Is metadata reuse also not allowed if EventProcessorStatus.DISABLED? -- To view, visit http://gerrit.cloudera.org:8080/21437 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide8f1f6bf017e9a040b53bb5d5291ff2ea3e0d18 Gerrit-Change-Number: 21437 Gerrit-PatchSet: 1 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 17 May 2024 19:24:58 +0000 Gerrit-HasComments: Yes
