Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/21437 )
Change subject: IMPALA-12277: Fix NullPointerException for partitioned inserts when EP is turned off ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/21437/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21437/1//COMMIT_MSG@11 PS1, Line 11: NullPointerException > What is the source of NPE? Where does it hit / manifest problem? Jira has more details about this. But to explain this in simple terms, with the event processor turned off, create a partitioned table from Impala and add partition (p=1) by inserting some values, at this point drop the partition (p=1) from the hive and insert some values into a partition(p=1), then we would hit NULL pointer exception because, we are reusing metadata while reloading the table, catalogd first removes it since it doesn't exist in HMS (fetch partitions from HMS) and then it validates each partition in the cache against the partitions from HMS, we would then hit precondition check for non-null partition names here: https://github.com/apache/impala/blob/master/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java#L1777 http://gerrit.cloudera.org:8080/#/c/21437/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/21437/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1748 PS1, Line 1748: > Do you mean "not active or not healthy." ? Discard this change. This is not completely addressing the concern. I have uploaded a new patchset. http://gerrit.cloudera.org:8080/#/c/21437/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1751 PS1, Line 1751: debugAction, partitionToEventId, reason, catalogTimeline); > This line remains unchanged for a long time since Fri Dec 18 14:31:24 (IMPA Same as above -- To view, visit http://gerrit.cloudera.org:8080/21437 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide8f1f6bf017e9a040b53bb5d5291ff2ea3e0d18 Gerrit-Change-Number: 21437 Gerrit-PatchSet: 4 Gerrit-Owner: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Mon, 20 May 2024 17:53:20 +0000 Gerrit-HasComments: Yes
