Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21437 )
Change subject: IMPALA-12277: Fix NullPointerException for partitioned inserts when EP is turned off ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/21437/9/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/21437/9/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@508 PS9, Line 508: ((MetastoreEventsProcessor) metastoreEventProcessor_).getStatus() > IEventProcessorStatus.DISABLED is configured when NoOpEventProcessor is req Agree. But what I meant is, MetastoreEventProcessor itself can never transition to EventProcessorStatus.DISABLED. If that is the case, a Precondition.checkState(eventProcessorStatus_ != EventProcessorStatus.DISABLED) can be added inside MetastoreEventProcessor.updateStatus() or MetastoreEventProcessor.getStatus(). $ git grep -n -e "updateStatus" -e "eventProcessorStatus_ =" fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java:610: private EventProcessorStatus eventProcessorStatus_ = EventProcessorStatus.STOPPED; fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java:770: updateStatus(EventProcessorStatus.ACTIVE); fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java:837: if (eventProcessorStatus_ == EventProcessorStatus.PAUSED) { fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java:840: updateStatus(EventProcessorStatus.PAUSED); fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java:929: updateStatus(EventProcessorStatus.ACTIVE); fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java:948: updateStatus(EventProcessorStatus.STOPPED); fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java:1085: updateStatus(EventProcessorStatus.NEEDS_INVALIDATE); fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java:1095: updateStatus(EventProcessorStatus.ERROR); fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java:1414: public synchronized void updateStatus(EventProcessorStatus toStatus) { fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java:1415: eventProcessorStatus_ = toStatus; fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java:3897: eventsProcessor_.updateStatus(EventProcessorStatus.NEEDS_INVALIDATE); fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java:3902: eventsProcessor_.updateStatus(EventProcessorStatus.ERROR); -- To view, visit http://gerrit.cloudera.org:8080/21437 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide8f1f6bf017e9a040b53bb5d5291ff2ea3e0d18 Gerrit-Change-Number: 21437 Gerrit-PatchSet: 9 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Wed, 22 May 2024 20:31:55 +0000 Gerrit-HasComments: Yes
