Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21437 )
Change subject: IMPALA-12277: Fix NullPointerException for partitioned inserts when EP is turned off ...................................................................... Patch Set 10: (5 comments) http://gerrit.cloudera.org:8080/#/c/21437/10/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/21437/10/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7473 PS10, Line 7473: lodaing nit: loading http://gerrit.cloudera.org:8080/#/c/21437/10/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7480 PS10, Line 7480: update.setTransaction_id(MetastoreShim.openTransaction(msClient : .getHiveClient())); Should this call abortTransaction first for the failed update? http://gerrit.cloudera.org:8080/#/c/21437/10/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7482 PS10, Line 7482: TException e) Which operation can throw this exception? http://gerrit.cloudera.org:8080/#/c/21437/10/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7485 PS10, Line 7485: return updateCatalogImpl(update, false); // we should only retry once. LOG the retry attempt before recursing? http://gerrit.cloudera.org:8080/#/c/21437/10/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/21437/10/tests/custom_cluster/test_events_custom_configs.py@1266 PS10, Line 1266: def test_no_ep_metadata_reload_for_insert(self, unique_database): Add comment about what this test do. -- To view, visit http://gerrit.cloudera.org:8080/21437 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide8f1f6bf017e9a040b53bb5d5291ff2ea3e0d18 Gerrit-Change-Number: 21437 Gerrit-PatchSet: 10 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Thu, 06 Jun 2024 22:01:30 +0000 Gerrit-HasComments: Yes
