Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/21418 )
Change subject: IMPALA-12705: Add /catalog-ha-info page on Statestore to show catalog HA information ...................................................................... Patch Set 12: (5 comments) It looks good to me overall, just some minor issues with code style. http://gerrit.cloudera.org:8080/#/c/21418/12/be/src/statestore/statestore.h File be/src/statestore/statestore.h: http://gerrit.cloudera.org:8080/#/c/21418/12/be/src/statestore/statestore.h@514 PS12, Line 514: TStatestoreSubscriberType::type subscriber_type() const { : return subscriber_type_; : } nit: It can be written in one line to be consistent with the context. http://gerrit.cloudera.org:8080/#/c/21418/12/be/src/statestore/statestore.h@585 PS12, Line 585: const nit: Unnecessary const http://gerrit.cloudera.org:8080/#/c/21418/12/be/src/statestore/statestore.cc File be/src/statestore/statestore.cc: http://gerrit.cloudera.org:8080/#/c/21418/12/be/src/statestore/statestore.cc@2189 PS12, Line 2189: !FLAGS_enable_statestored_ha || (FLAGS_enable_statestored_ha && is_active_ I think we can simplify the code by reversing this if-else block, like this: if (FLAGS_enable_statestored_ha && !is_active_) { document->AddMember("is_active_statestored", false, document->GetAllocator()); return; } http://gerrit.cloudera.org:8080/#/c/21418/12/be/src/statestore/statestore.cc@2198 PS12, Line 2198: document->AddMember( : "has_active_catalogd", has_active_catalogd, document->GetAllocator()); nit: It's better to standardize the indentation style here and in the subsequent code. http://gerrit.cloudera.org:8080/#/c/21418/12/common/thrift/StatestoreService.thrift File common/thrift/StatestoreService.thrift: http://gerrit.cloudera.org:8080/#/c/21418/12/common/thrift/StatestoreService.thrift@222 PS12, Line 222: registration_time nit: Missing a semicolon. -- To view, visit http://gerrit.cloudera.org:8080/21418 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If85f6a827ae8180d13caac588b92af0511ac35e3 Gerrit-Change-Number: 21418 Gerrit-PatchSet: 12 Gerrit-Owner: ttttttz <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Reviewer: ttttttz <[email protected]> Gerrit-Comment-Date: Thu, 30 May 2024 08:27:16 +0000 Gerrit-HasComments: Yes
