ttttttz has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21418 )

Change subject: IMPALA-12705: Add /catalog_ha_info page on Statestore to show 
catalog HA information
......................................................................


Patch Set 14:

(5 comments)

Thank you for your patient guidance!

http://gerrit.cloudera.org:8080/#/c/21418/13/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:

http://gerrit.cloudera.org:8080/#/c/21418/13/tests/webserver/test_web_pages.py@1184
PS13, Line 1184: h
> Ack
Ack


http://gerrit.cloudera.org:8080/#/c/21418/14/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:

http://gerrit.cloudera.org:8080/#/c/21418/14/tests/webserver/test_web_pages.py@1141
PS14, Line 1141: ImpalaTestSuite
> This is not CustomClusterTestSuite. The Impala cluster is not restarted for
Ack


http://gerrit.cloudera.org:8080/#/c/21418/14/tests/webserver/test_web_pages.py@1171
PS14, Line 1171: disable_catalog_ha
> function name should be started with test_
Ack


http://gerrit.cloudera.org:8080/#/c/21418/14/tests/webserver/test_web_pages.py@1174
PS14, Line 1174: 
@CustomClusterTestSuite.with_args(start_args="--enable_catalogd_ha")
> Could we set parameters if the class is not CustomClusterTestSuite? Is Impa
Ack


http://gerrit.cloudera.org:8080/#/c/21418/14/tests/webserver/test_web_pages.py@1175
PS14, Line 1175: enable_catalog_ha
> function name should be started with test_
Ack



--
To view, visit http://gerrit.cloudera.org:8080/21418
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If85f6a827ae8180d13caac588b92af0511ac35e3
Gerrit-Change-Number: 21418
Gerrit-PatchSet: 14
Gerrit-Owner: ttttttz <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Reviewer: Zihao Ye <[email protected]>
Gerrit-Reviewer: ttttttz <[email protected]>
Gerrit-Comment-Date: Sun, 02 Jun 2024 14:57:04 +0000
Gerrit-HasComments: Yes

Reply via email to