Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21484 )
Change subject: IMPALA-12800: Add null slots cache ...................................................................... Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/21484/3/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/21484/3/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@541 PS3, Line 541: private final Set<PrivilegeRequest> privilegeReqs = new LinkedHashSet<>(); : : // List of PrivilegeRequest to custom authorization failure error message. : // Tracks all privilege requests on catalog objects that need a custom : // error message returned to avoid exposing existence of catalog objects. : private final List<Pair<PrivilegeRequest, String>> maskedPrivilegeReqs = : new ArrayList<>(); : : // accesses to catalog objects > Switched to Guava cache, I don't see any performance loss compared to what Done http://gerrit.cloudera.org:8080/#/c/21484/7/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/21484/7/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@2979 PS7, Line 2979: getIfPresent(nullTuplePred); you can use get(K key, Callable<? extends V> loader) here. http://gerrit.cloudera.org:8080/#/c/21484/7/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@2992 PS7, Line 2992: if (LOG.isDebugEnabled() && globalState_.nullSlotsCache != null) nit: can return early here, saving indentation. if (!LOG.isDebugEnabled() || globalState_.nullSlotsCache == null) return; http://gerrit.cloudera.org:8080/#/c/21484/7/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@2994 PS7, Line 2994: MemoryMeter meter = MemoryMeter.builder().build(); Just a note: We probably should log WARNING if any of GlobalState field member's size grows prohibitively large. I'm not sure if it is possible to meter everything though. -- To view, visit http://gerrit.cloudera.org:8080/21484 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib63f5553284f21f775d2097b6c5d6bbb63699acd Gerrit-Change-Number: 21484 Gerrit-PatchSet: 7 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 07 Jun 2024 21:48:12 +0000 Gerrit-HasComments: Yes
