Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21484 )
Change subject: IMPALA-12800: Add null slots cache ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/21484/7/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/21484/7/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@2979 PS7, Line 2979: getIfPresent(nullTuplePred); > you can use get(K key, Callable<? extends V> loader) here. It requires some extra exception handling, but doesn't seem too bad. Done. http://gerrit.cloudera.org:8080/#/c/21484/7/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@2992 PS7, Line 2992: if (LOG.isDebugEnabled() && globalState_.nullSlotsCache != null) > nit: can return early here, saving indentation. Done http://gerrit.cloudera.org:8080/#/c/21484/7/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@2994 PS7, Line 2994: MemoryMeter meter = MemoryMeter.builder().build(); > Just a note: I really don't want to meter everything by default. -- To view, visit http://gerrit.cloudera.org:8080/21484 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib63f5553284f21f775d2097b6c5d6bbb63699acd Gerrit-Change-Number: 21484 Gerrit-PatchSet: 7 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 07 Jun 2024 22:23:26 +0000 Gerrit-HasComments: Yes
