Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21492 )
Change subject: IMPALA-12370: allow converting timestamps to UTC when writing Kudu ...................................................................... Patch Set 3: Code-Review+1 (2 comments) This looks good to me. However I haven't dug into the Impala's internals when converting and comparing timestamps. I hope corresponding functionality has enough test coverage, so if there was an issue, it would be caught by pre-commit tests. http://gerrit.cloudera.org:8080/#/c/21492/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21492/2//COMMIT_MSG@16 PS2, Line 16: To be able to read back Kudu tables written by Impala correctly : convert_kudu_utc_timestamps and write_kudu_utc_timestamps need to : have the same value. > The reason for adding a new flag (and not changing the name of the old one) Ah, I see. That makes sense to me -- thanks for the clarification. http://gerrit.cloudera.org:8080/#/c/21492/2/common/thrift/ImpalaService.thrift File common/thrift/ImpalaService.thrift: http://gerrit.cloudera.org:8080/#/c/21492/2/common/thrift/ImpalaService.thrift@882 PS2, Line 882: When true, UNIXTIME_MICRO columns read from Kudu will be interpreted as UTC an > TIMESTAMP vs UNIXTIME_MICROS: Impala uses TIMESTAMP as SQL type (and does n Thanks for the update -- this is stated with more clarity now. -- To view, visit http://gerrit.cloudera.org:8080/21492 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb4995a64e042e7bb261fcc6e6bf7ffce61e9bd1 Gerrit-Change-Number: 21492 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Mon, 10 Jun 2024 18:49:15 +0000 Gerrit-HasComments: Yes
