Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21492 )
Change subject: IMPALA-12370: Allow converting timestamps to UTC when writing to Kudu ...................................................................... Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/21492/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21492/3//COMMIT_MSG@7 PS3, Line 7: writing > nit: writing to Done http://gerrit.cloudera.org:8080/#/c/21492/3//COMMIT_MSG@7 PS3, Line 7: Allow > nit: Allow Done http://gerrit.cloudera.org:8080/#/c/21492/3//COMMIT_MSG@9 PS3, Line 9: commit > nit: commit, Done http://gerrit.cloudera.org:8080/#/c/21492/3//COMMIT_MSG@16 PS3, Line 16: All DMLs supported with Kudu tables are affected affected: : INSERT, UPSERT, UPDATE, DELETE : > Maybe a PlannerTest to see that to_utc_timestamp / utc_to_unix_micros is ad Added planner tests. http://gerrit.cloudera.org:8080/#/c/21492/3//COMMIT_MSG@16 PS3, Line 16: All DMLs supported with Kudu tables are affected affected: : INSERT, UPSERT, UPDATE, DELETE : > Add validation in impala::ValidateQueryOptions. I am not 100% sure about the correct way to handle the query options. If the two have different values, then UPDATE/DELETE can be completely wrong. Meanwhile this is an advanced undocumented feature, so we can assume that the user knows what they are doing. If this will be properly supported in the future, then I think that it would be better to allow setting it per table with a table property that overrides the query options. But I wouldn't do this in the current commit. http://gerrit.cloudera.org:8080/#/c/21492/3/fe/src/main/java/org/apache/impala/util/ExprUtil.java File fe/src/main/java/org/apache/impala/util/ExprUtil.java: http://gerrit.cloudera.org:8080/#/c/21492/3/fe/src/main/java/org/apache/impala/util/ExprUtil.java@126 PS3, Line 126: /** : * Wraps 'timestampExpr' in to_utc_timestamp() that converts > Add comment for this method. I think this wrap timestampExpr inside a Funct Done -- To view, visit http://gerrit.cloudera.org:8080/21492 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb4995a64e042e7bb261fcc6e6bf7ffce61e9bd1 Gerrit-Change-Number: 21492 Gerrit-PatchSet: 5 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Fri, 14 Jun 2024 16:05:13 +0000 Gerrit-HasComments: Yes
