Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21455 )
Change subject: IMPALA-13075: Cap memory usage for ExprValuesCache at 256KB ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/21455/5/be/src/exec/hash-table.cc File be/src/exec/hash-table.cc: http://gerrit.cloudera.org:8080/#/c/21455/5/be/src/exec/hash-table.cc@376 PS5, Line 376: _exprs_) / sam > If I understand correctly than capacity_ can be 1 or N*64. Isn't it possibl Change the formula to use double in patch set 7. The -8 in max_capacity calculation is to account for 1 extra BitMap overhead. Therefore, if mem_per_row = 4KB, max_capacity will be equal to 63.998046875. Thus, expect capacity_ = 63. -- To view, visit http://gerrit.cloudera.org:8080/21455 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee27cbbe8d3100301d05a6516b62c45975a8d0e0 Gerrit-Change-Number: 21455 Gerrit-PatchSet: 7 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 10 Jun 2024 21:35:46 +0000 Gerrit-HasComments: Yes
