Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21455 )
Change subject: IMPALA-13075: Cap memory usage for ExprValuesCache at 256KB ...................................................................... Patch Set 7: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/21455/7/tests/common/test_dimensions.py File tests/common/test_dimensions.py: http://gerrit.cloudera.org:8080/#/c/21455/7/tests/common/test_dimensions.py@119 PS7, Line 119: create_table_format_dimension the create...dimension functions below could be shorter by calling this functions http://gerrit.cloudera.org:8080/#/c/21455/7/tests/query_test/test_join_queries.py File tests/query_test/test_join_queries.py: http://gerrit.cloudera.org:8080/#/c/21455/7/tests/query_test/test_join_queries.py@218 PS7, Line 218: parquet/snap/bloc Is there a reason for using this instead of default parquet/none? -- To view, visit http://gerrit.cloudera.org:8080/21455 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee27cbbe8d3100301d05a6516b62c45975a8d0e0 Gerrit-Change-Number: 21455 Gerrit-PatchSet: 7 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 13 Jun 2024 12:31:18 +0000 Gerrit-HasComments: Yes
