Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21441 )
Change subject: IMPALA-12562: Cast double and float to string with exact presicion ...................................................................... IMPALA-12562: Cast double and float to string with exact presicion The builtin functions casttostring(DOUBLE) and casttostring(FLOAT) printed more digits when converting double and float values to string values. This patch fixes this by switching to use the existing methods DoubleToBuffer and FloatToBuffer, which are simple and fast implementations to print necessary digits. Testing: - Add end-to-end tests to verify the fixes - Add benchmarks for modified functions - Update tests in expr-test Change-Id: Icd79c55dd57dc0fa13e4ec11c2284ef2800e8b1a Reviewed-on: http://gerrit.cloudera.org:8080/21441 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/benchmarks/expr-benchmark.cc M be/src/exprs/cast-functions-ir.cc M be/src/exprs/expr-test.cc M testdata/workloads/functional-query/queries/QueryTest/exprs.test 4 files changed, 173 insertions(+), 71 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/21441 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Icd79c55dd57dc0fa13e4ec11c2284ef2800e8b1a Gerrit-Change-Number: 21441 Gerrit-PatchSet: 7 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]>
