Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21441 )
Change subject: IMPALA-12562: Cast double and float to string with exact presicion ...................................................................... Patch Set 5: > Patch Set 4: > > > Patch Set 4: Verified-1 > > > > Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/10665/ > > Tests show some real failures: > https://jenkins.impala.io/job/ubuntu-20.04-from-scratch/2665/testReport/ Related tests have been updated in PS5. We use boost::lexical_cast to cast double/float to string in TestCast, which also loses precisions. So I use string values directly for comparison. -- To view, visit http://gerrit.cloudera.org:8080/21441 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icd79c55dd57dc0fa13e4ec11c2284ef2800e8b1a Gerrit-Change-Number: 21441 Gerrit-PatchSet: 5 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Fri, 24 May 2024 14:59:18 +0000 Gerrit-HasComments: No
