Saurabh Katiyal has posted comments on this change. ( http://gerrit.cloudera.org:8080/21426 )
Change subject: IMPALA-12216: Print timestamp for impala-shell errors ...................................................................... Patch Set 9: (11 comments) > Patch Set 6: > > (1 comment) Done, Now we have timestamps similar to log lines : [localhost:21050] default> select * from test where code = sleep ( 10000); Steet(ans00. TransportExceotion's in pinoTmoala 2024-06-17 22:41:44 [Exception] type=<class 'thrift. transport. TTransport.TTransportException'> in PingImpalaHS2Service. TSocket read o bytes 2024-06-17 22:41:44 [Exception] type=<class 'socket.error'> in CloseSession. [Errno 32] Broken pipe 2024-06-17 22:41:44 [Warning] close session RPC failed: ‹class 'socket.error'> [Errno 32] Broken pipe http://gerrit.cloudera.org:8080/#/c/21426/4/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/21426/4/shell/impala_client.py@1615 PS4, Line 1615: i > flake8: E231 missing whitespace after ',' Done http://gerrit.cloudera.org:8080/#/c/21426/4/shell/impala_client.py@1615 PS4, Line 1615: print("%s [%s] %s" % (time.strftime("%Y-%m-%d %H:%M:%S", time.localtime()), type, msg), > flake8: E302 expected 2 blank lines, found 1 Done http://gerrit.cloudera.org:8080/#/c/21426/4/shell/impala_client.py@1620 PS4, Line 1620: # method log_timestamp prints timestamp with custom message > flake8: E302 expected 2 blank lines, found 1 Done http://gerrit.cloudera.org:8080/#/c/21426/4/shell/impala_client.py@1622 PS4, Line 1622: > flake8: W292 no newline at end of file Done http://gerrit.cloudera.org:8080/#/c/21426/6/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/21426/6/shell/impala_client.py@1623 PS6, Line 1623: > Can we put the timestamp at the beginning? So the format is more like a log Done http://gerrit.cloudera.org:8080/#/c/21426/8/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/21426/8/shell/impala_client.py@1615 PS8, Line 1615: , > flake8: E231 missing whitespace after ',' Done http://gerrit.cloudera.org:8080/#/c/21426/8/shell/impala_client.py@1616 PS8, Line 1616: , > flake8: E203 whitespace before ',' Done http://gerrit.cloudera.org:8080/#/c/21426/8/shell/impala_client.py@1621 PS8, Line 1621: , > flake8: E231 missing whitespace after ',' Done http://gerrit.cloudera.org:8080/#/c/21426/4/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/21426/4/shell/impala_shell.py@1461 PS4, Line 1461: > flake8: E231 missing whitespace after ',' Done http://gerrit.cloudera.org:8080/#/c/21426/4/shell/impala_shell.py@1473 PS4, Line 1473: d > flake8: E231 missing whitespace after ',' Done http://gerrit.cloudera.org:8080/#/c/21426/4/shell/impala_shell.py@1505 PS4, Line 1505: > flake8: E231 missing whitespace after ',' Done -- To view, visit http://gerrit.cloudera.org:8080/21426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944 Gerrit-Change-Number: 21426 Gerrit-PatchSet: 9 Gerrit-Owner: Saurabh Katiyal <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Saurabh Katiyal <[email protected]> Gerrit-Comment-Date: Tue, 18 Jun 2024 07:33:22 +0000 Gerrit-HasComments: Yes
