Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21426 )
Change subject: IMPALA-12216: Print timestamp for impala-shell errors ...................................................................... Patch Set 9: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/21426/9/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/21426/9/shell/impala_client.py@1612 PS9, Line 1612: def log_exception_with_timestamp(e, type="Exception", msg=""): Could be simply log_exception http://gerrit.cloudera.org:8080/#/c/21426/9/shell/impala_client.py@1619 PS9, Line 1619: def log_timestamp(type="Exception", msg=""): If I didn't miss something this is only used with "WARNING" - maybe it could be log_warning? -- To view, visit http://gerrit.cloudera.org:8080/21426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944 Gerrit-Change-Number: 21426 Gerrit-PatchSet: 9 Gerrit-Owner: Saurabh Katiyal <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Saurabh Katiyal <[email protected]> Gerrit-Comment-Date: Tue, 18 Jun 2024 10:08:10 +0000 Gerrit-HasComments: Yes
