Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/10347 )
Change subject: Fix diagnostics path to not include the parent dir structure ...................................................................... Patch Set 2: Why don't you put JIRA in your commit message? As far as I know, most changes include JIRA in the commit message. But some of the merged changes did not exist in JIRA. I think it's a good idea to include JIRA consistently even with small changes. What do you think? -- To view, visit http://gerrit.cloudera.org:8080/10347 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I540f6c228a0315780d45cf11961f124478b5dd0c Gerrit-Change-Number: 10347 Gerrit-PatchSet: 2 Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Kim Jin Chul <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Wed, 09 May 2018 23:36:46 +0000 Gerrit-HasComments: No
