Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10347 )
Change subject: Fix diagnostics path to not include the parent dir structure ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/10347/2/bin/diagnostics/collect_diagnostics.py File bin/diagnostics/collect_diagnostics.py: http://gerrit.cloudera.org:8080/#/c/10347/2/bin/diagnostics/collect_diagnostics.py@450 PS2, Line 450: # collection_root_dir is an absoulte path. There is no point in preserving its > nit: its Done http://gerrit.cloudera.org:8080/#/c/10347/2/bin/diagnostics/collect_diagnostics.py@451 PS2, Line 451: # entire directory structure in the archive, so set the arcname accordingly. > nit: "archive, so set" Done -- To view, visit http://gerrit.cloudera.org:8080/10347 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I540f6c228a0315780d45cf11961f124478b5dd0c Gerrit-Change-Number: 10347 Gerrit-PatchSet: 3 Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Kim Jin Chul <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Thu, 10 May 2018 05:49:02 +0000 Gerrit-HasComments: Yes
