Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/21557 )
Change subject: IMPALA-13088: Use RoaringBitmap instead of sorted vector of int64s ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/21557/1/be/src/exec/iceberg-delete-builder.cc File be/src/exec/iceberg-delete-builder.cc: http://gerrit.cloudera.org:8080/#/c/21557/1/be/src/exec/iceberg-delete-builder.cc@260 PS1, Line 260: deletes.AddElements(positions); CRoaring does not handle out-of-memory. We should maybe add some reserve check here before calling it's functions. http://gerrit.cloudera.org:8080/#/c/21557/1/be/src/exec/iceberg-delete-builder.cc@303 PS1, Line 303: RETURN_IF_ERROR(AddToDeletedRows(prev_file_path, pos_buffer)); Should sort pos_buffer here to guarantee performance of bitmap insert. -- To view, visit http://gerrit.cloudera.org:8080/21557 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib769965d094149e99c43e0044914d9ecccc76107 Gerrit-Change-Number: 21557 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Comment-Date: Wed, 26 Jun 2024 13:58:07 +0000 Gerrit-HasComments: Yes
