Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21557 )
Change subject: IMPALA-13088: Use RoaringBitmap instead of sorted vector of int64s ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/21557/1/be/src/exec/iceberg-delete-builder.cc File be/src/exec/iceberg-delete-builder.cc: http://gerrit.cloudera.org:8080/#/c/21557/1/be/src/exec/iceberg-delete-builder.cc@285 PS1, Line 285: std::make_unsigned_t<int64_t> We could simply use 'uint64_t' for the cast or leave the conversion implicit. We could also DCHECK that the original signed position is not negative. See also L297. http://gerrit.cloudera.org:8080/#/c/21557/1/be/src/thirdparty/roaring/README.md File be/src/thirdparty/roaring/README.md: http://gerrit.cloudera.org:8080/#/c/21557/1/be/src/thirdparty/roaring/README.md@29 PS1, Line 29: need Nit: "needs". http://gerrit.cloudera.org:8080/#/c/21557/1/be/src/util/roaring-bitmap-test.cc File be/src/util/roaring-bitmap-test.cc: http://gerrit.cloudera.org:8080/#/c/21557/1/be/src/util/roaring-bitmap-test.cc@29 PS1, Line 29: 33 If we inserted 11, why should 33 be in the bitmap? http://gerrit.cloudera.org:8080/#/c/21557/1/be/src/util/roaring-bitmap.h File be/src/util/roaring-bitmap.h: http://gerrit.cloudera.org:8080/#/c/21557/1/be/src/util/roaring-bitmap.h@33 PS1, Line 33: BulkContext Couldn't we use 'roaring64_bulk_context_t' directly? Or are you concerned about accidentally using the copy constructor/assignment operator? -- To view, visit http://gerrit.cloudera.org:8080/21557 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib769965d094149e99c43e0044914d9ecccc76107 Gerrit-Change-Number: 21557 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Fri, 28 Jun 2024 10:45:39 +0000 Gerrit-HasComments: Yes
