Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/21566 )
Change subject: IMPALA-13193: RuntimeFilter on parquet dictionary should evaluate NULL values ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/21566/3/be/src/exec/parquet/hdfs-parquet-scanner.cc File be/src/exec/parquet/hdfs-parquet-scanner.cc: http://gerrit.cloudera.org:8080/#/c/21566/3/be/src/exec/parquet/hdfs-parquet-scanner.cc@1927 PS3, Line 1927: if (!column_has_match && col_metadata.statistics.null_count > 0) { > This is a property of parquet. Do we ever see incorrect or uninitialized st That makes sense, relying on statistical information might be unreliable. Perhaps we should remove col_metadata.statistics.null_count > 0 and always perform the null value eval when !column_has_match. -- To view, visit http://gerrit.cloudera.org:8080/21566 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0f69405c0c08feb47141d080a828847e5094163f Gerrit-Change-Number: 21566 Gerrit-PatchSet: 3 Gerrit-Owner: ttttttz <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Reviewer: ttttttz <[email protected]> Gerrit-Comment-Date: Tue, 09 Jul 2024 02:45:17 +0000 Gerrit-HasComments: Yes
