Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21566 )
Change subject: IMPALA-13193: RuntimeFilter on parquet dictionary should evaluate NULL values ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/21566/5/be/src/exec/parquet/hdfs-parquet-scanner.cc File be/src/exec/parquet/hdfs-parquet-scanner.cc: http://gerrit.cloudera.org:8080/#/c/21566/5/be/src/exec/parquet/hdfs-parquet-scanner.cc@1929 PS5, Line 1929: !has_set_null_count I think if the null_count is not set, evaluating runtime filters on the dictionary is unsafe since we don't know whether there are NULLs in the column. In such case, we should skip evaluating these runtime filters (i.e. set should_eval_runtime_filter to false at L1888), unless we have other ways to determine whether there are NULLs. -- To view, visit http://gerrit.cloudera.org:8080/21566 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0f69405c0c08feb47141d080a828847e5094163f Gerrit-Change-Number: 21566 Gerrit-PatchSet: 5 Gerrit-Owner: ttttttz <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Reviewer: ttttttz <[email protected]> Gerrit-Comment-Date: Wed, 10 Jul 2024 09:41:26 +0000 Gerrit-HasComments: Yes
