Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21559 )
Change subject: IMPALA-13161: Fix column index overflow in DelimitedTextParser ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/21559/2/be/src/exec/delimited-text-parser.inline.h File be/src/exec/delimited-text-parser.inline.h: http://gerrit.cloudera.org:8080/#/c/21559/2/be/src/exec/delimited-text-parser.inline.h@76 PS2, Line 76: if (column_idx_ < num_cols_) ++column_idx_; > Why would we call "AddColumn" more times than num_cols_? num_cols_ comes from the table metadata. The actual data line could have more field delimiters so we need to iterate them until the next line delimiter. https://github.com/apache/impala/blob/e419545c1c2b6fa0b6d23643d3b2eb0faa4dce52/be/src/exec/delimited-text-parser.h#L110-L112 -- To view, visit http://gerrit.cloudera.org:8080/21559 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I527a8971e92e270d5576c2155e4622dd6d43d745 Gerrit-Change-Number: 21559 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 10 Jul 2024 04:41:02 +0000 Gerrit-HasComments: Yes
