Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21559 )
Change subject: IMPALA-13161: Fix column index overflow in DelimitedTextParser ...................................................................... IMPALA-13161: Fix column index overflow in DelimitedTextParser DelimitedTextParser tracks the current column index inside the current row that is under parsing. The row could have arbitrary numbers of fields. The index, 'column_idx_', is defined as int type which could overflow when there are more than 2^31 fields in the row. This index is only used to check whether the current column should be materialized. It doesn't make sense to track the index if it's larger than the number of columns of the table. This patch fixes the overflow issue by only bumping 'column_idx_' when it's smaller than the number of columns of the table. Tests - Add e2e test Change-Id: I527a8971e92e270d5576c2155e4622dd6d43d745 Reviewed-on: http://gerrit.cloudera.org:8080/21559 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/exec/delimited-text-parser.inline.h M tests/query_test/test_delimited_text.py 2 files changed, 19 insertions(+), 1 deletion(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/21559 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I527a8971e92e270d5576c2155e4622dd6d43d745 Gerrit-Change-Number: 21559 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]>
