Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21571 )
Change subject: IMPALA-13209: Optimize ConvertRowBatchTime in ExchangeNode ...................................................................... Patch Set 4: Code-Review+1 (3 comments) Only found a few nits. This is a great change, I have a query where I have ConvertRowBatchTime=29s568ms on average, and it is on the BUILD side of a JOIN, so it blocks lots of SCAN threads, thus blocking whole query execution. Next week I'll do a measurement with your patch being applied. http://gerrit.cloudera.org:8080/#/c/21571/4/be/src/exec/exchange-node.cc File be/src/exec/exchange-node.cc: http://gerrit.cloudera.org:8080/#/c/21571/4/be/src/exec/exchange-node.cc@211 PS4, Line 211: (int) nit: we usually prefer static_cast instead of C-style cast. http://gerrit.cloudera.org:8080/#/c/21571/4/be/src/exec/exchange-node.cc@211 PS4, Line 211: (int64_t) We prefer static_cast instead of C-style cast. Or this could be the template parameter of std::min: std::min<int64_t>(rows_to_copy, limit_ - rows_returned()); http://gerrit.cloudera.org:8080/#/c/21571/4/be/src/runtime/row-batch.cc File be/src/runtime/row-batch.cc: http://gerrit.cloudera.org:8080/#/c/21571/4/be/src/runtime/row-batch.cc@565 PS4, Line 565: nit: extra space -- To view, visit http://gerrit.cloudera.org:8080/21571 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab94315364e8886da1ae01cf6af623812a2da9cb Gerrit-Change-Number: 21571 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 12 Jul 2024 22:13:33 +0000 Gerrit-HasComments: Yes
