Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21571 )
Change subject: IMPALA-13209: Optimize ConvertRowBatchTime in ExchangeNode ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/21571/4/be/src/exec/exchange-node.cc File be/src/exec/exchange-node.cc: http://gerrit.cloudera.org:8080/#/c/21571/4/be/src/exec/exchange-node.cc@211 PS4, Line 211: > We prefer static_cast instead of C-style cast. Or this could be the templat Done http://gerrit.cloudera.org:8080/#/c/21571/4/be/src/exec/exchange-node.cc@211 PS4, Line 211: > nit: we usually prefer static_cast instead of C-style cast. Done http://gerrit.cloudera.org:8080/#/c/21571/4/be/src/runtime/row-batch.cc File be/src/runtime/row-batch.cc: http://gerrit.cloudera.org:8080/#/c/21571/4/be/src/runtime/row-batch.cc@565 PS4, Line 565: n > nit: extra space Done -- To view, visit http://gerrit.cloudera.org:8080/21571 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab94315364e8886da1ae01cf6af623812a2da9cb Gerrit-Change-Number: 21571 Gerrit-PatchSet: 5 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 15 Jul 2024 12:51:23 +0000 Gerrit-HasComments: Yes
