Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21426 )
Change subject: IMPALA-12216: Print timestamp for impala-shell errors ...................................................................... Patch Set 14: (2 comments) http://gerrit.cloudera.org:8080/#/c/21426/14/tests/custom_cluster/test_hs2_fault_injection.py File tests/custom_cluster/test_hs2_fault_injection.py: http://gerrit.cloudera.org:8080/#/c/21426/14/tests/custom_cluster/test_hs2_fault_injection.py@184 PS14, Line 184: 20 To make the code more readable, can we make this a constant variable? Is it the length of a prefix string? http://gerrit.cloudera.org:8080/#/c/21426/12/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/21426/12/tests/shell/test_shell_interactive.py@340 PS12, Line 340: assert impalad.wait_for_num_in_flight_queries(0) How does the new format impact this? -- To view, visit http://gerrit.cloudera.org:8080/21426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944 Gerrit-Change-Number: 21426 Gerrit-PatchSet: 14 Gerrit-Owner: Saurabh Katiyal <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Saurabh Katiyal <[email protected]> Gerrit-Comment-Date: Mon, 15 Jul 2024 06:19:30 +0000 Gerrit-HasComments: Yes
