Saurabh Katiyal has posted comments on this change. ( http://gerrit.cloudera.org:8080/21426 )
Change subject: IMPALA-12216: Print timestamp for impala-shell errors ...................................................................... Patch Set 14: > Patch Set 14: > > (2 comments) > Regarding 1st review, Yes, It's date time stamp prefix that i have removed before asserting the value to void flaky behavior of test: ++++++++++++++++++++++++ 2024-07-15 12:49:27 [Exception] type=<class 'socket.error'> in FetchResults. [Errno 4] Interrupted system call 2024-07-15 12:49:27 [Warning] Cancelling Query 2024-07-15 12:49:27 [Warning] close session RPC failed: <class 'shell_exceptions.QueryCancelledByShellException'> ++++++++++++++++++++++++ [20:] will ignore first 20 characters for 2024-07-15 12:49:27 part before asserting with expected string > Regarding 2nd review: We now explicitly added keyword keyword [Cancelled] with timestamp (initial ask of this improvement Jira) and the test was used to check no cancel keyword should be there. ++++++++++++++++++++++++ Scan Progress:[ ] 0% Query Progress:[ ] 0% ^C Cancelling Query Opened TCP connection to localhost:21050 2024-07-15 12:51:43 [Cancelled] [localhost:21050] default> ++++++++++++++++++++++++ -- To view, visit http://gerrit.cloudera.org:8080/21426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944 Gerrit-Change-Number: 21426 Gerrit-PatchSet: 14 Gerrit-Owner: Saurabh Katiyal <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Saurabh Katiyal <[email protected]> Gerrit-Comment-Date: Mon, 15 Jul 2024 07:28:35 +0000 Gerrit-HasComments: No
