Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21563 )
Change subject: IMPALA-13194: Fast-serialize position delete records ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/21563/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21563/1//COMMIT_MSG@13 PS1, Line 13: e > Done Not yet done :) http://gerrit.cloudera.org:8080/#/c/21563/1/be/src/runtime/krpc-data-stream-sender.cc File be/src/runtime/krpc-data-stream-sender.cc: http://gerrit.cloudera.org:8080/#/c/21563/1/be/src/runtime/krpc-data-stream-sender.cc@943 PS1, Line 943: i64 > Actual type would be 'unique_ptr<impala::KrpcDataStreamSender::Channel>&', I think it would be an improvement, for example for reading "ch.get()" - if we know it is a unique_ptr, we know that ".get()" simply returns the pointer and doesn't call an actual method of the channel object. http://gerrit.cloudera.org:8080/#/c/21563/2/be/src/runtime/krpc-data-stream-sender.cc File be/src/runtime/krpc-data-stream-sender.cc: http://gerrit.cloudera.org:8080/#/c/21563/2/be/src/runtime/krpc-data-stream-sender.cc@188 PS2, Line 188: GetSerializationBatch It could be private. Right now it's not used anywhere else and I don't like the idea of giving out the owning pointer to external clients. -- To view, visit http://gerrit.cloudera.org:8080/21563 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6095f318e3d06dedb4197681156b40dd2a326c6f Gerrit-Change-Number: 21563 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 16 Jul 2024 11:59:30 +0000 Gerrit-HasComments: Yes
